[ 
https://issues.apache.org/jira/browse/STORM-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065650#comment-14065650
 ] 

ASF GitHub Bot commented on STORM-279:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/162#discussion_r15087142
  
    --- Diff: logback/cluster.xml ---
    @@ -52,7 +52,7 @@
       </appender>
     
       <appender name="METRICS" 
class="ch.qos.logback.core.rolling.RollingFileAppender">
    -    <file>${storm.home}/logs/metrics.log</file>
    +    <file>${storm.log.dir}/metrics.log</file>
         <rollingPolicy 
class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
           <fileNamePattern>${storm.home}/logs/metrics.log.%i</fileNamePattern>
    --- End diff --
    
    We need to change the fileNamePattern here too.


> cluster.xml doesn't take in STORM_LOG_DIR values
> ------------------------------------------------
>
>                 Key: STORM-279
>                 URL: https://issues.apache.org/jira/browse/STORM-279
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Sriharsha Chintalapani
>         Attachments: STORM-279.patch, STORM-279_1.patch
>
>
> cluster.xml config points ${storm.home} if user defines a different location 
> for storm logs via STORM_LOG_DIR it won't take in that value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to