[ 
https://issues.apache.org/jira/browse/STORM-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065657#comment-14065657
 ] 

ASF GitHub Bot commented on STORM-279:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/162#discussion_r15087312
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -463,6 +463,8 @@
         :distributed [supervisor storm-id port worker-id]
         (let [conf (:conf supervisor)
               storm-home (System/getProperty "storm.home")
    +          storm-log-dir (if (System/getProperty "storm.log.dir")
    +                          (System/getProperty "storm.log.dir") (str 
storm-home "/logs"))
    --- End diff --
    
    This could be:
    
    ```Clojure
    storm-log-dir (or (System/getProperty "storm.log.dir") (str storm-home 
"/logs"))
    ```



> cluster.xml doesn't take in STORM_LOG_DIR values
> ------------------------------------------------
>
>                 Key: STORM-279
>                 URL: https://issues.apache.org/jira/browse/STORM-279
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Sriharsha Chintalapani
>         Attachments: STORM-279.patch, STORM-279_1.patch
>
>
> cluster.xml config points ${storm.home} if user defines a different location 
> for storm logs via STORM_LOG_DIR it won't take in that value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to