[
https://issues.apache.org/jira/browse/STORM-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066450#comment-14066450
]
ASF GitHub Bot commented on STORM-414:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/196#discussion_r15117713
--- Diff: storm-core/src/multilang/py/storm.py ---
@@ -135,8 +135,8 @@ def fail(tup):
def reportError(msg):
sendMsgToParent({"command": "error", "msg": msg})
-def log(msg):
- sendMsgToParent({"command": "log", "msg": msg})
+def log(msg, level=2):
--- End diff --
Could we add in some other methods that are specific to the levels. It
think it would make using them a lot simpler. log{Trace,Debug,Warn,Error} You
can put in logInfo too, but it feels a bit redundant.
> support logging level to multilang protocol spout and bolt
> ----------------------------------------------------------
>
> Key: STORM-414
> URL: https://issues.apache.org/jira/browse/STORM-414
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating, 0.9.3-incubating
> Reporter: DashengJu
> Priority: Minor
> Fix For: 0.9.3-incubating
>
>
> @mahall create a PR: https://github.com/apache/incubator-storm/pull/24 ,
> Added logging level to multilang protocol spout and bolt. But he closed it
> with no reason.
> @msukmanowsky create a PR before to apache:
> https://github.com/nathanmarz/storm/pull/626 , Allow ShellBolts to optionally
> specify the logging level. But he did not modify ShellSpout and storm.py.
> This improvement add optional logging level to Multilang Protocol's log
> method. And add implementation in python and ruby.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
