[
https://issues.apache.org/jira/browse/STORM-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067851#comment-14067851
]
ASF GitHub Bot commented on STORM-414:
--------------------------------------
Github user dashengju commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/196#discussion_r15148217
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -158,6 +157,33 @@ private void querySubprocess() {
}
}
+ private void handleLog(ShellMsg shellMsg) {
+ String msg = shellMsg.getMsg();
+ msg = "ShellLog" + _process.getProcessInfoString() + msg;
--- End diff --
I have noticed the white space. Because _process.getProcessInfoString()
return a string with white space at begin and end, so I did not add white space
here.
And I think the best way is remove white space in
_process.getProcessInfoString()'s return, and add white space in here
explicitly, and I have change the code.
> support logging level to multilang protocol spout and bolt
> ----------------------------------------------------------
>
> Key: STORM-414
> URL: https://issues.apache.org/jira/browse/STORM-414
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating, 0.9.3-incubating
> Reporter: DashengJu
> Priority: Minor
> Fix For: 0.9.3-incubating
>
>
> @mahall create a PR: https://github.com/apache/incubator-storm/pull/24 ,
> Added logging level to multilang protocol spout and bolt. But he closed it
> with no reason.
> @msukmanowsky create a PR before to apache:
> https://github.com/nathanmarz/storm/pull/626 , Allow ShellBolts to optionally
> specify the logging level. But he did not modify ShellSpout and storm.py.
> This improvement add optional logging level to Multilang Protocol's log
> method. And add implementation in python and ruby.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
