Github user Parth-Brahmbhatt commented on the pull request:

    https://github.com/apache/incubator-storm/pull/190#issuecomment-50082444
  
    Added a unit test on nimbus to verify that the credentials will be 
populated as part of submit topology. I did not find any equivalent unit test 
for renewers so I added renewer test as well, I think I found a bug in nimbus's 
renew-credentials method. When old and new credentials do not match, the method 
calls 
    (.set-credentials! storm-cluster-state id new-creds) which seems to be 
missing a parameter topology-conf so I changed it to (.set-credentials! 
storm-cluster-state id new-creds topology-conf). 
    
    The test passed after this change but please confirm that this is indeed a 
bug and let me know if you want to file a separate JIRA for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to