Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/190#discussion_r15414517
--- Diff: storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java ---
@@ -109,6 +111,27 @@ public static IPrincipalToLocal
GetPrincipalToLocalPlugin(Map storm_conf) {
}
/**
+ * Get all the Nimbus Auto cred plugins that users want to use.
+ * @param topologyConf topologyConfiguration to use.
+ * @return nimbus auto credential plugins.
+ */
+ public static Collection<INimbusCredentialPlugin>
getNimbusAutoCredPlugins(Map topologyConf) {
--- End diff --
Again I am not sure we want this to come from the topology conf. I would
rather have a list of plugins that the administrator has approved, and let
those plugins look at the topology conf to decide if they are going to do
anything or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
