Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/177#issuecomment-50174405
Your logic seems fine to me. Like I said I am not super familiar with the
nodejs APIs.
I would, however like to see tests and formal packaging for it. If we are
going to support it, we should fully support it.
I also am curious how likely others would be to use this library too.
Although it is a relatively small amount of code, it could become a maintenance
issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
