Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/177#issuecomment-52682866
Great to hear that the latest code is in prod now.
I ran into a few problems, but none of them are really your code. The test
didn't fail when I didn't have nodejs installed. but this is because of a bug
in util.clj STORM-461
Also I really hate having two copies of storm.js in there, but we have the
same thing for ruby and python. I files STORM-462 for this too.
The last problem I has was with documentation. We don't indicate anywhere
what needs to be installed to build/run the tests. Could you add a section to
DEVELOPER.md that indicates that you need ruby, python, and nodejs for all of
the tests to pass.
I also assume that you are going to be able to help support this long term?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
