Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/190#discussion_r15419864
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
    @@ -1046,7 +1047,10 @@
                                     (dissoc storm-conf 
STORM-ZOOKEEPER-TOPOLOGY-AUTH-SCHEME STORM-ZOOKEEPER-TOPOLOGY-AUTH-PAYLOAD))
                     total-storm-conf (merge conf storm-conf)
                     topology (normalize-topology total-storm-conf topology)
    +                nimbus-autocred-plugins 
(AuthUtils/getNimbusAutoCredPlugins total-storm-conf)
    --- End diff --
    
    I can see how this can be a security hole when the user passes his own 
implementation and act as nimbus to get delegation tokens as some other user. 
Good catch. I will go with your approach. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to