Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/242#discussion_r16714479
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -424,7 +424,7 @@
(if bolt-summs
(mapfn bolt-summs)
(mapfn spout-summs)))
- :link (url-format "/component.html?id=%s&topology_id=%s"
id storm-id)
+ :link (url-format "/component.html?id=%s&topology_id=%s"
(url-encode id) (url-encode storm-id))
--- End diff --
Why do we need to double encode the id and storm-id? url-format already
encodes them once.
```
(defn url-format [fmt & args]
(String/format fmt
(to-array (map #(url-encode (str %)) args))))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
