Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/242#issuecomment-53427732
OK so mustache will do HTML escaping with the ```{{var}}``` like syntax,
but it will not do URL encoding. So we have added in URL encoded ids to the
result of the REST APIs to allow us to not bother with doing the URL encoding
in the browser. That seems OK I guess. But why are we not url decoding the
url parameters in the REST API any more? Is it because the ring framework
already decodes them for us? And I am really confused why in the
visualization-data function we need to double url encode the ids in the link?
From the look of it, it is because we take those parameters and place them in a
new URL for the rest call. I would much rather have the browser encode them
again when making them a part of the URL. encodeURIComponent should be what we
want and is a standard part of javascript.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
