Github user nathanmarz commented on the pull request:
https://github.com/apache/incubator-storm/pull/236#issuecomment-53480325
A few things:
1. I made a comment about inserting a type hint to avoid reflection
2. To be clear, the only queue you're monitoring here is the receive queue
for executors?
3. I need to be convinced more that the interactions with the
DisruptorQueue are thread-safe. This is critical code, so we have to be extra
careful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
