HrishikeshUchake opened a new pull request, #1628: URL: https://github.com/apache/stormcrawler/pull/1628
#1578 Fix NOP logger configuration in core/pom.xml ## Description This PR fixes issue #1578 by addressing SLF4J NOP logger warnings that occur during testing. The solution adds the `slf4j-simple` dependency to the core module's test scope. **Problem:** Tests were generating multiple SLF4J errors as described in #1578: [ERROR] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". [ERROR] SLF4J: Defaulting to no-operation (NOP) logger implementation [ERROR] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [ERROR] SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder". [ERROR] SLF4J: Defaulting to no-operation MDCAdapter implementation. **Solution:** Added `slf4j-simple` dependency with test scope to provide a simple logging implementation for tests without affecting runtime dependencies. ## Changes Made - Added `slf4j-simple` dependency (version 2.0.17) to `core/pom.xml` with test scope - Resolves SLF4J NOP logger warnings during test execution as reported in #1578 ### For all changes - [x] Is there a issue associated with this PR? Is it referenced in the commit message? (Issue #1578) - [x] Does your PR title start with `#XXXX` where `XXXX` is the issue number you are trying to resolve? (#1578) - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? - [x] Is the code properly formatted with `mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false`? ### For code changes - [x] Have you ensured that the full suite of tests is executed via `mvn clean verify`? - [ ] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file? (Not needed - slf4j-simple is Apache 2.0 licensed) - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file? (Not needed - already covered by existing SLF4J dependencies) ## Testing - [x] Verified that SLF4J NOP logger warnings from #1578 are eliminated during test execution - [x] Confirmed dependency is scoped to test only and doesn't affect runtime ## Notes - The `slf4j-simple` dependency is Apache 2.0 licensed and compatible with ASF projects - Test-scoped dependency ensures no impact on production runtime - Version 2.0.17 aligns with project's SLF4J version requirements - Fixes issue #1578 Closes #1578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
