HrishikeshUchake commented on PR #1628: URL: https://github.com/apache/stormcrawler/pull/1628#issuecomment-3185135047
@rzo1 I've addressed your feedback: ✅ **Centralized version management**: Added `slf4j-simple.version` property to root POM and moved dependency to `dependencyManagement` ✅ **Extended to external modules**: Added `slf4j-simple` dependency to opensearch, solr, and urlfrontier modules as requested ✅ **Bonus fix**: Added exclusions to `storm-client` dependency to eliminate the "multiple SLF4J providers" warnings we discussed **Results:** - ✅ Original NOP logger issue #1578 is completely resolved - ✅ Multiple SLF4J providers warnings are eliminated - ✅ All tests run cleanly with proper logging - ✅ Follows Maven dependency management best practices The changes are ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
