abhinav-phi opened a new pull request, #2120: URL: https://github.com/apache/stormcrawler/pull/2120
Fixes #2084. The try/catch wrapped the whole chain: when a filter threw, the catch logged the exception and fell through to the value the last successful filter had produced, so callers such as `StatusEmitterBolt.filterOutlink` treated the URL as accepted and every filter after the one that threw was skipped — including the regex exclusions the archetype places last. - the try/catch now sits inside the loop: it logs which filter threw and returns null, so a broken chain cannot widen what the crawl accepts - `main()` applies the same verdict so the command line tool agrees with the topology - a counter (`getExceptionsCount()`) records how often it happens - `FastURLFilter.Rule` rejects a rule line without a recognised type at load time instead of building a rule with a null type that throws when evaluated This changes behaviour for topologies that currently have a throwing filter and did not notice: those URLs start being dropped instead of emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
