abhinav-phi commented on PR #2120: URL: https://github.com/apache/stormcrawler/pull/2120#issuecomment-5574634153
Thanks — pushed: - field renamed to `exceptionsCount` (all three uses). - `System.err` line dropped; the timing line's `=> null` output is the single report. - `rejectionShortensTheChain` rewritten per your suggestion: a `CountingURLFilter` sits after the thrower (new `urlfilters-throwing-counting.json`) and asserts `EVALUATIONS == 0`, so the test now proves the chain is cut short rather than repeating the rejection assertion. - On `getExceptionsCount()` being unread: left it public as the observation point for operators embedding the chain — wiring it into the metrics UI needs a `TopologyContext`, which `URLFilters` doesn't have; happy to add that plumbing in a follow-up if you'd rather have it on-dash from day one. CI red was my Windows format-check gap (the plugin's validate silently no-ops there); the changed files are reformatted with google-java-format 1.35.0, matching the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
