The GitHub Actions job "Java CI with Maven" on 
stormcrawler.git/issue-2085-spout-scheme-check has failed.
Run started by GitHub user abhinav-phi (triggered by rzo1).

Head commit for run:
c9a67d0809f01c9a8954e4d5914c836ae3a4424b / abhinav-phi <[email protected]>
Report unemittable rows to the status stream (#2085)

Review feedback on #2123:

- a row whose URL the spout refuses to emit is reported to the status
  updater as Status.ERROR on the status stream: it is removed from the
  store instead of staying there and coming back with every query,
  which bounded the skipped.scheme loop and gives the operator a
  signal other than one warn per row per query
- the scheme comparison lowercases with Locale.ROOT; the previous
  default-locale lowercase would reject every URL on a Turkish worker
- a null from SimpleURLBuffer.next() is handled instead of throwing
- the throttleQueries javadoc formatting fixed, the redundant
  buffer.hasNext() check dropped

Report URL: https://github.com/apache/stormcrawler/actions/runs/34152596620

With regards,
GitHub Actions via GitBox

Reply via email to