The GitHub Actions job "Java CI with Maven" on 
stormcrawler.git/issue-2085-spout-scheme-check has failed.
Run started by GitHub user abhinav-phi (triggered by dpol1).

Head commit for run:
f8564faea6c816885d5b5b40ba59e45dc7f01abe / abhinav-phi <[email protected]>
Split the shipped protocols string into schemes; wire spout status stream 
(#2085)

Review feedback on #2123:

- the protocols key was parsed with loadListFromConf alone, which
  returns a comma-separated string as one entry: the shipped
  "http,https,file" became a single unmatchable scheme and every
  stored URL was rejected. The key is now split on commas with
  surrounding whitespace tolerated, exactly like ProtocolFactory
  parses it; tests cover the shipped string, an explicit list and
  whitespace forms
- declaring the status stream routes nothing by itself: the archetype
  crawler.flux files (urlfrontier, opensearch, solr) now connect the
  spout to the status updater on Constants.StatusStreamName with the
  same url-field grouping the other status producers use, so rejected
  rows actually reach the store and are removed. internals.adoc
  documents the required wiring for hand-built topologies
- SpoutStatusStreamWiringTest parses the archetype topology and fails
  if the spout-to-status-updater connection is missing

Report URL: https://github.com/apache/stormcrawler/actions/runs/34248381078

With regards,
GitHub Actions via GitBox

Reply via email to