abhinav-phi commented on PR #2118: URL: https://github.com/apache/stormcrawler/pull/2118#issuecomment-5601065859
@jnioche the shipped archetype keys were broken before this PR: the three `crawler-conf.yaml` files set `parse.tika.config.file`, but `ParserBolt` has read `parser.tika.config.file` (with an `s`) since 3.x — `ParserBolt.java:332`. So on `main` the archetype value was never picked up and the bolt always fell back to the default `tika-config.xml`. I only renamed the YAML key so the setting the example config already declares is actually honoured — no code key changed. Happy to go the other way instead (rename the code to `parse.tika.config.file` to match the example configs) if you'd rather not touch the shipped YAML; say which you prefer. The other half of that diff, the value `tika-config.xml` → `tika-config.json` (code default and the examples), is forced by the Tika 4 upgrade: `TikaConfig` built from XML is gone, `TikaLoader` reads JSON configs — so the file must be JSON for the config to load at all. The tests (`TikaConfigTest`) now use `test-tika-config.json` for the same reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
