abhinav-phi commented on code in PR #2118:
URL: https://github.com/apache/stormcrawler/pull/2118#discussion_r4462674078
##########
external/tika/src/main/resources/tika-config.json:
##########
@@ -0,0 +1,9 @@
+{
Review Comment:
checked main. the key mismatch is fixed: all three archetypes now use
`parser.tika.config.file`, and `ParserBolt` reads the same key. on the
service-loader part, Tika 4's `service-loader` config class is empty (no
fields), and `initializableProblemHandler` / `loadErrorHandler` only survive in
Tika's CHANGES.txt, not in the 4.x config classes. so those two attributes
cannot be carried into the JSON config; the old XML was not valid for Tika 4.
the parser exclusion is carried as `default-parser.exclude:
["tesseract-ocr-parser"]`. the temp file is kept until `cleanup()` because the
forked JVMs under `parser.tika.timeout` still need it, with `deleteOnExit()` as
the safety net, and `cleanup()` calls `Files.deleteIfExists`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
