abhinav-phi commented on PR #2128: URL: https://github.com/apache/stormcrawler/pull/2128#issuecomment-5606911863
All three addressed in a0b8bd5d (rebased onto current main): 1. Credential alignment with #2126: manual hops now reuse the configurable http.credentials.headers classification and credentialsAllowed transport policy. Origin change OR unauthenticated target strips every credential header (Proxy-Authorization excluded, like #2126). Initial request also respects the policy now. Tests: credentialsSurviveASameOriginHop (kept) + true cross-origin credentialsAreStrippedOnACrossOriginHop covering Authorization and X-Api-Key (previous test was same-origin asserting survival). 2. Relative Location: when chain stops, Location is resolved against last request URL before returning, so /start -> /nested/hop -> next with max 1 yields /nested/next. Pinned by relativeLocationResolvesAgainstLastHop. 3. DNS cleanup: every hop Call tracked; intermediate entries removed (final reported), finally cleans all on exception paths. Pinned by dnsEntriesAreCleanedForEveryHop. All 7 OkHttpFollowRedirectsTest green locally; format/checkstyle clean. Note: this branch duplicates #2126 credential policy until #2126 merges, then will rebase to single source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
