abhinav-phi commented on PR #2128: URL: https://github.com/apache/stormcrawler/pull/2128#issuecomment-5609289581
Thanks — all three redirect-chain issues are fixed in this push: 1. **Credentials** (a0b8bd5d): redirect hops reuse the #2126 credential-header classification and strip those headers on origin change or when the target is not authenticated (plain http, trust-all, unverified host unless http.credentials.allow.insecure). OkHttpFollowRedirectsTest covers same-origin survival vs cross-origin stripping. One correction on top (7147e4a9): the first version gated cookies and Basic auth on the initial request too, which broke HttpProtocolCookieTest and the robots.txt auth test — the initial request goes to the URL the crawl explicitly targeted, so configured credentials are sent there as before; the redirect hops are the trust boundary. All three tests green again. 2. **Relative Location** (a0b8bd5d): when a chain stops at an intermediate hop, the returned Location is resolved against the last request URL, so FetcherBolt resolves the same target instead of one level too high. 3. **DNS timing** (a0b8bd5d): every hop's Call is tracked and its DNStimes entry cleaned up, including exception paths. mvn -pl core verify -DCI_ENV=true is green on the branch. Please re-review when you get a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
