jnioche commented on code in PR #2251:
URL: https://github.com/apache/stormcrawler/pull/2251#discussion_r4337736496
##########
core/src/main/java/org/apache/stormcrawler/util/CharsetIdentification.java:
##########
@@ -61,6 +61,18 @@ public class CharsetIdentification {
*/
public static String getCharsetFast(
final Metadata metadata, final byte[] content, final int
maxLengthCharsetDetection) {
+ return getCharsetFast(metadata, content, maxLengthCharsetDetection,
"");
Review Comment:
These 3-arg overloads now silently mean "ignore the prefix". Fetched
metadata almost always carries one ("protocol." by default), so any caller that
keeps using the familiar signature keeps the bug without warning, as
`JsRenderingDetector` does. Could we deprecate the 3-arg
`getCharset`/`getCharsetFast`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
