jnioche commented on code in PR #2251:
URL: https://github.com/apache/stormcrawler/pull/2251#discussion_r4341284762
##########
core/src/main/java/org/apache/stormcrawler/util/CharsetIdentification.java:
##########
@@ -61,6 +61,18 @@ public class CharsetIdentification {
*/
public static String getCharsetFast(
final Metadata metadata, final byte[] content, final int
maxLengthCharsetDetection) {
+ return getCharsetFast(metadata, content, maxLengthCharsetDetection,
"");
Review Comment:
thanks @nicoscandolo
actually, since we are about to do a major release, now would be a good time
to simply remove them. besides, I doubt that they are used directly by any code
written by users so the impact is low anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
