Github user prabathabey commented on a diff in the pull request:
https://github.com/apache/stratos/pull/277#discussion_r27852451
--- Diff:
components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/applications/ApplicationUtils.java
---
@@ -191,52 +128,56 @@ public static StringBuilder getTextPayload (String
appId, String groupName, Stri
return payloadBuilder;
}
- public static PayloadData createPayload(String appId, String
groupName, CartridgeInfo cartridgeInfo, String subscriptionKey, int tenantId,
String clusterId,
+ public static PayloadData createPayload(String appId, String
groupName, Cartridge cartridge, String subscriptionKey, int tenantId, String
clusterId,
--- End diff --
The code would have looked much cleaner if an instance of an appropriate
bean class was used to wrap all these different pieces of parameters and passed
it into the method as an argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
