Github user prabathabey commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/277#discussion_r27852529
  
    --- Diff: 
components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/applications/ApplicationUtils.java
 ---
    @@ -259,7 +200,7 @@ public static PayloadData createPayload(String appId, 
String groupName, Cartridg
             return payloadData;
         }
     
    -    private static BasicPayloadData createBasicPayload(String appId, 
String groupName, CartridgeInfo cartridge,
    +    private static BasicPayloadData createBasicPayload(String appId, 
String groupName, Cartridge cartridge,
    --- End diff --
    
    The same comment I'd made previously upon introducing a bean class to wrap 
all these parameters (if applicable) and pass it into the method as an argument 
would apply here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to