+1 (binding) Chris
However this +1 is due to the fact that you're using the WIP disclaimer which sort of allows you to do what you want ... I reviewed the RC as if it had the normal incubation disclaimer so perhaps for the next release you could even switch to the normal disclaimer (which is a prerequisite for becoming a TLP) I checked: [OK] Download all staged artifacts under the url specified in the release vote email into a directory we’ll now call download-dir. [OK] Verify the signatures is correct [OK] Check if the signatures references an Apache email address. [OK] Verify the SHA512 hashes: [OK] Unzip the archives (Rat did have some issues processing the ZIP of the installer sources directly though) [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle (See remarks following). [OK] Verify the staged source README, RELEASE_NOTE files correspond to those in the extracted source bundle. [OK] Run RAT externally to ensure there are no surprises (Some files are missing Apache headers). [NOT OK (for "extensions")] Some files have a copyright header from the FZI without being listed in the LICENSE or NOTICE [NOT OK (for "extensions")] The archive should contain copies of the license texts [OK] No unexpected binaries [OK] Search for SNAPSHOT references [OK] Build the project according to the information in the README.md file. [OK] Build the project with all tests enabled and an empty maven local repo: by appending -Dmaven.repo.local=../.m2. (After adding "inherited=false" to the assembly plugin config) Here some more findings you should have a look at: Core: [MINOR] You are not referencing the latest apache parent (Version: 23) Remarks: - LICENSE is referencing MaterialIcons-Regular.eot, MaterialIcons-Regular.ttf, MaterialIcons-Regular.woff and MaterialIcons-Regular.woff2 but these files can't be found in the archive - LICENSE references: streampipes-measurement-units/src/main/java/com.github.jqudt which is actually streampipes-measurement-units/src/main/java/com/github/jqudt - NOTOCE: You might want to think about adding: <inceptionYear>2019</inceptionYear> to all root poms so the NOTICE contains a from-to year entry and not just a to-year. - README.md (I think you should reference the Apache Slack and not the streampipes one) - README.md https://cwiki.apache.org/confluence/display/STREAMPIPES/Home doesn't seem to exist ... - README.md doesn't contain information on really how to build SP - RELEASE_NOTES: Are you folks really following sematic versioning? I can see at least one removal, which is a breaking change and you're still at 0.x.x ... Extensions: [NOT OK] the "extensions" module doesn't contain copies of the license texts of used licenses [MINOR] 17 Files have a "Copyright 2017 FZI Forschungszentrum Informatik" style header (In this case they would have to be listed in the LICENSE) Remarks: - README.md (I think you should reference the Apache Slack and not the streampipes one) - README.md https://cwiki.apache.org/confluence/display/STREAMPIPES/Home doesn't seem to exist ... - README.md doesn't contain information on really how to build SP - RELEASE_NOTES: Are you folks really following sematic versioning? I can see at least one removal, which is a breaking change and you're still at 0.x.x ... - When running a mvn clean install the build fails as the parent pom references an assembly file which is located in core and not available in the extensions. Perhaps adding an "<inherited>false</inherited>" to the plugin declaration in the parent pom would help. Installer: Remarks: - Couldn't run RAT on the installer zip directly ... Am 05.05.20, 20:53 schrieb "Dominik Riemer" <[email protected]>: Hi, Apache StreamPipes (Incubating) 0.66.0 has been staged and it's time to vote on accepting it for release. If approved, we will seek final release approval from the IPMC. Voting will be open for 72 hours. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass, but everyone is welcome to vote! Three artifacts are relevant for this vote: incubator-streampipes, staged at [1], available in Nexus at [2], release tag: release/0.66.0, hash for the release tag: b8c23e6785eaad79da6dd03072f2c1dcbfa467b4 incubator-streampipes-extensions, staged at [3], release tag: release/0.66.0, hash for the release tag: 44b7dd13c75058811a001f1aa6b3f6805285eb2d incubator-streampipes-installer, staged at [4], release tag: release/0.66.0, hash for the release tag: 1a8054239d8f42d66ee95e7b1282708f5f1266b0 Per [5] "Before voting +1, [P]PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." A release validation guide is available at [6]. The KEYS file is available at [7] [ ] +1 accept (indicate what you validated - e.g. performed the checklist at the end of [6]) [ ] -1 reject (explanation required) Thanks for taking your time for validating this release! Dominik [1] https://dist.apache.org/repos/dist/dev/incubator/streampipes/core/0.66.0/rc1 [2] https://repository.apache.org/content/repositories/orgapachestreampipes-1006 [3] https://dist.apache.org/repos/dist/dev/incubator/streampipes/extensions/0.66 .0/rc1 [4] https://dist.apache.org/repos/dist/dev/incubator/streampipes/installer/0.66. 0/rc1 [5] https://www.apache.org/dev/release.html#approving-a-release [6] https://cwiki.apache.org/confluence/display/STREAMPIPES/Validating+a+release [7] https://dist.apache.org/repos/dist/dev/incubator/streampipes/KEYS
