bossenti commented on code in PR #2117:
URL: https://github.com/apache/streampipes/pull/2117#discussion_r1379634378
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/preprocessing/elements/SendToBrokerAdapterSink.java:
##########
@@ -86,9 +87,12 @@ protected void sendToBroker(byte[] event) throws
RuntimeException {
producer.publish(event);
}
- protected abstract EventProducer makeProducer(T protocol);
-
- public abstract void modifyProtocolForDebugging(T protocol);
+ public void modifyProtocolForDebugging(TransportProtocol protocol) {
+ protocol.setBrokerHostname("localhost");
Review Comment:
Does this also work in a Kubernetes deployment?
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/AdapterPipelineGenerator.java:
##########
@@ -51,31 +39,8 @@ public AdapterPipeline generatePipeline(AdapterDescription
adapterDescription) {
}
}
- private SendToBrokerAdapterSink<?> getAdapterSink(AdapterDescription
adapterDescription) {
- var prioritizedProtocol =
- getMessagingSettings().getPrioritizedProtocols().get(0);
-
- if (isPrioritized(prioritizedProtocol, JmsTransportProtocol.class)) {
- return new SendToJmsAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
KafkaTransportProtocol.class)) {
- return new SendToKafkaAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
MqttTransportProtocol.class)) {
- return new SendToMqttAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
PulsarTransportProtocol.class)) {
- return new SendToPulsarAdapterSink(adapterDescription);
- } else {
- return new SendToNatsAdapterSink(adapterDescription);
- }
- }
-
- private boolean isPrioritized(SpProtocol prioritizedProtocol,
- Class<?> protocolClass) {
- return
prioritizedProtocol.getProtocolClass().equals(protocolClass.getCanonicalName());
- }
-
- private MessagingSettings getMessagingSettings() {
- var client = new
StreamPipesClientResolver().makeStreamPipesClientInstance();
- return client.adminApi().getMessagingSettings();
+ private SendToBrokerAdapterSink getAdapterSink(AdapterDescription
adapterDescription) {
+ return new SendToBrokerAdapterSink(adapterDescription);
Review Comment:
Great improvement 👍🏼
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/AdapterPipelineGenerator.java:
##########
@@ -51,31 +39,8 @@ public AdapterPipeline generatePipeline(AdapterDescription
adapterDescription) {
}
}
- private SendToBrokerAdapterSink<?> getAdapterSink(AdapterDescription
adapterDescription) {
- var prioritizedProtocol =
- getMessagingSettings().getPrioritizedProtocols().get(0);
-
- if (isPrioritized(prioritizedProtocol, JmsTransportProtocol.class)) {
- return new SendToJmsAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
KafkaTransportProtocol.class)) {
- return new SendToKafkaAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
MqttTransportProtocol.class)) {
- return new SendToMqttAdapterSink(adapterDescription);
- } else if (isPrioritized(prioritizedProtocol,
PulsarTransportProtocol.class)) {
- return new SendToPulsarAdapterSink(adapterDescription);
- } else {
- return new SendToNatsAdapterSink(adapterDescription);
- }
- }
-
- private boolean isPrioritized(SpProtocol prioritizedProtocol,
- Class<?> protocolClass) {
- return
prioritizedProtocol.getProtocolClass().equals(protocolClass.getCanonicalName());
- }
-
- private MessagingSettings getMessagingSettings() {
- var client = new
StreamPipesClientResolver().makeStreamPipesClientInstance();
- return client.adminApi().getMessagingSettings();
+ private SendToBrokerAdapterSink getAdapterSink(AdapterDescription
adapterDescription) {
+ return new SendToBrokerAdapterSink(adapterDescription);
Review Comment:
Great improvement 👍🏼
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/preprocessing/elements/SendToBrokerAdapterSink.java:
##########
@@ -86,9 +87,12 @@ protected void sendToBroker(byte[] event) throws
RuntimeException {
producer.publish(event);
}
- protected abstract EventProducer makeProducer(T protocol);
-
- public abstract void modifyProtocolForDebugging(T protocol);
+ public void modifyProtocolForDebugging(TransportProtocol protocol) {
+ protocol.setBrokerHostname("localhost");
+ if (protocol instanceof KafkaTransportProtocol) {
+ ((KafkaTransportProtocol) protocol).setKafkaPort(9094);
Review Comment:
The kafka port might not always be `9094` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
