dominikriemer commented on code in PR #2117:
URL: https://github.com/apache/streampipes/pull/2117#discussion_r1380059505
##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/preprocessing/elements/SendToBrokerAdapterSink.java:
##########
@@ -86,9 +87,12 @@ protected void sendToBroker(byte[] event) throws
RuntimeException {
producer.publish(event);
}
- protected abstract EventProducer makeProducer(T protocol);
-
- public abstract void modifyProtocolForDebugging(T protocol);
+ public void modifyProtocolForDebugging(TransportProtocol protocol) {
+ protocol.setBrokerHostname("localhost");
+ if (protocol instanceof KafkaTransportProtocol) {
+ ((KafkaTransportProtocol) protocol).setKafkaPort(9094);
Review Comment:
This is only executed when SP_DEBUG is set - in these cases we expect that
users use the CLI with these settings.
If we want to change that, this can be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
