tenthe commented on code in PR #2124:
URL: https://github.com/apache/streampipes/pull/2124#discussion_r1381226247
##########
streampipes-extensions/streampipes-connect-adapters/src/main/java/org/apache/streampipes/connect/GeneralAdaptersExtensionModuleExport.java:
##########
@@ -28,35 +28,42 @@
import org.apache.streampipes.connect.adapters.ti.TISensorTag;
import
org.apache.streampipes.connect.adapters.wikipedia.WikipediaEditedArticlesAdapter;
import
org.apache.streampipes.connect.adapters.wikipedia.WikipediaNewArticlesAdapter;
-import org.apache.streampipes.extensions.management.model.SpServiceDefinition;
-import
org.apache.streampipes.extensions.management.model.SpServiceDefinitionBuilder;
-import org.apache.streampipes.service.extensions.ExtensionsModelSubmitter;
+import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
+import org.apache.streampipes.extensions.api.declarer.IExtensionModuleExport;
+import org.apache.streampipes.extensions.api.migration.IModelMigrator;
+import org.apache.streampipes.extensions.api.pe.IStreamPipesPipelineElement;
-public class ConnectAdapterInit extends ExtensionsModelSubmitter {
+import java.util.Collections;
+import java.util.List;
- public static void main(String[] args) {
- new ConnectAdapterInit().init();
+public class GeneralAdaptersExtensionModuleExport implements
IExtensionModuleExport {
+
+ @Override
+ public List<StreamPipesAdapter> adapters() {
+ return List.of(
+ //new GdeltAdapter(),
Review Comment:
I would suggest that we open an issue to deprecate some of the adapters in
the `streampipes-connect-adapters` module for the upcoming release, so that we
can remove them in 0.94.0.
The module has several adapters that are out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
