dominikriemer commented on code in PR #2124: URL: https://github.com/apache/streampipes/pull/2124#discussion_r1381504761
########## streampipes-rest-extensions/src/main/java/org/apache/streampipes/rest/extensions/migration/DataSinkMigrationResource.java: ########## @@ -47,7 +45,6 @@ public class DataSinkMigrationResource extends MigrateExtensionsResource< @POST @Consumes(MediaType.APPLICATION_JSON) @JacksonSerialized - @PreAuthorize(AuthConstants.IS_ADMIN_ROLE) Review Comment: I removed this for now because this functionality required a dependency to `streampipes-rest` in the `streampipes-rest-extensions` module, which pulled in all core dependencies in the extension modules, adding a lot of overhead. Since there's currently no authorization for extensions in place, we can address this later if needed. ########## installer/compose/docker-compose.minimal.yml: ########## @@ -0,0 +1,146 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +version: "3.4" + +# global logging +x-logging: + &default-logging + options: + max-size: '12m' + max-file: '5' + driver: json-file + +services: + + # StreamPipes services + backend: + image: "${SP_DOCKER_REGISTRY}/backend-nats:${SP_VERSION}" + depends_on: + - consul + - couchdb + environment: + - SP_PRIORITIZED_PROTOCOL=nats + volumes: + - backend:/root/.streampipes + logging: *default-logging + restart: unless-stopped + networks: + spnet: + + ui: + image: "${SP_DOCKER_REGISTRY}/ui:${SP_VERSION}" + ports: + - "80:8088" + depends_on: + - couchdb + - consul + - backend + volumes: + - nginx:/etc/nginx/ + logging: *default-logging + restart: unless-stopped + networks: + spnet: + + consul: + image: consul:1.14.3 + environment: + - "CONSUL_LOCAL_CONFIG={\"disable_update_check\": true}" + - "CONSUL_BIND_INTERFACE=eth0" + - "CONSUL_HTTP_ADDR=0.0.0.0" + entrypoint: + - consul + - agent + - -server + - -bootstrap-expect=1 + - -data-dir=/consul/data + - -node=consul-one + - -bind={{ GetInterfaceIP "eth0" }} + - -client=0.0.0.0 + - -enable-script-checks=true + - -ui + volumes: + - consul:/consul/data + logging: *default-logging + restart: unless-stopped + networks: + spnet: + ipv4_address: ${SP_CONSUL_CONTAINER_IP} + + couchdb: + image: couchdb:3.3.1 + environment: + - COUCHDB_USER=admin + - COUCHDB_PASSWORD=admin + volumes: + - couchdb:/opt/couchdb/data + logging: *default-logging + restart: unless-stopped + networks: + spnet: + + influxdb: + image: influxdb:2.6 + environment: + - INFLUXDB_DATA_ENGINE=tsm1 + - INFLUXDB_REPORTING_DISABLED=false + - INFLUXDB_ADMIN_ENABLED=true + - DOCKER_INFLUXDB_INIT_USERNAME=admin + - DOCKER_INFLUXDB_INIT_PASSWORD=sp-admin + - DOCKER_INFLUXDB_INIT_ADMIN_TOKEN=sp-admin + - DOCKER_INFLUXDB_INIT_ORG=sp + - DOCKER_INFLUXDB_INIT_BUCKET=sp + - DOCKER_INFLUXDB_INIT_MODE=${SP_INFLUX_INIT_MODE} + volumes: + - influxdb:/var/lib/influxdb + - influxdb2:/var/lib/influxdb2 + logging: *default-logging + restart: unless-stopped + networks: + spnet: + + nats: + image: nats + restart: unless-stopped + networks: + spnet: + + # Lite version pipeline elements + extensions-all-jvm: Review Comment: Good catch, will change that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
