tenthe commented on PR #2401: URL: https://github.com/apache/streampipes/pull/2401#issuecomment-1881270761
Hi @IsaakKrut, thanks a lot for submitting this pull request. I think this is a great improvement for users. I was wondering if this change might require a migration script, as it will affect existing adapters during system upgrades. Therefore, I would recommend providing an update script for the affected adapters. An example can be found in [1]. This change affected the PLC4X S7 adapter, where an alternative static property was added. In general, the update script should ensure that the changes are correctly propagated to the user configurations of the existing adapter instances. In your case, the `requiredDatatype` of the `FreeTextStaticProperty` must be changed from `Datatypes.String` to `Datatypes.Integer` within the update script. If you have any questions or need help with the implementation, please feel free to ask. [1] https://github.com/apache/streampipes/blob/dev/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/adapter/migration/Plc4xS7AdapterMigrationV1.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
