tenthe commented on PR #2401: URL: https://github.com/apache/streampipes/pull/2401#issuecomment-1895310502
Many thanks for the PR @IsaakKrut. Sorry for the late reply. The test looks good. @dominikriemer I was wondering what happens to the existing user input during configuration. The same migration is used for both, the description of the processing elements and for the instances, right? So I guess we need to check if a value is set in the original `StaticProperty` and set it for the new `StaticProperty` as well. For the `RosBridgeAdapterMigrationV1` this would mean that we add the 'original' value to the `FreeTextStaticProperty` created in line 52. Cheers, Philipp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
