dominikriemer commented on code in PR #2664:
URL: https://github.com/apache/streampipes/pull/2664#discussion_r1542792117
##########
streampipes-model-client/src/main/java/org/apache/streampipes/model/client/user/UserRegistrationData.java:
##########
@@ -18,32 +18,7 @@
package org.apache.streampipes.model.client.user;
-public class Token {
-
- private String principal;
- private String credentials;
-
- public Token(String principal, String credentials) {
- super();
- this.principal = principal;
- this.credentials = credentials;
- }
-
- public String getPrincipal() {
- return principal;
- }
-
- public void setPrincipal(String principal) {
- this.principal = principal;
- }
-
- public String getCredentials() {
- return credentials;
- }
-
- public void setCredentials(String credentials) {
- this.credentials = credentials;
- }
-
+import java.util.List;
+public record UserRegistrationData(String username, String password,
List<String> roleNames) {
Review Comment:
Is it necessary to change the field to `roleNames`? Since the `UserInfo`
object also uses `roles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
