bossenti commented on code in PR #2664:
URL: https://github.com/apache/streampipes/pull/2664#discussion_r1547239803
##########
streampipes-resource-management/src/main/java/org/apache/streampipes/resource/management/UserResourceManager.java:
##########
@@ -83,25 +88,31 @@ public Principal getAdminUser() {
.orElseThrow(IllegalArgumentException::new);
}
- public boolean registerUser(RegistrationData data) throws
UsernameAlreadyTakenException {
-
+ public void registerUser(UserRegistrationData data) throws
UsernameAlreadyTakenException {
try {
- if (db.checkUser(data.getUsername())) {
- throw new UsernameAlreadyTakenException("Username already taken");
- }
- String encryptedPassword =
PasswordUtil.encryptPassword(data.getPassword());
- List<Role> roles = data.getRoles().stream().map(Role::valueOf).toList();
- UserAccount user = UserAccount.from(data.getUsername(),
encryptedPassword, new HashSet<>(roles));
- user.setUsername(data.getUsername());
- user.setPassword(encryptedPassword);
- user.setAccountEnabled(false);
- db.storeUser(user);
- createTokenAndSendActivationMail(data.getUsername());
- } catch (NoSuchAlgorithmException | InvalidKeySpecException | IOException
e) {
- return false;
+ createUser(data);
+ createTokenAndSendActivationMail(data.username());
+ } catch (IOException e) {
+ LOG.error("Registration of user could not be completed: {}",
e.getMessage());
}
+ }
- return true;
+ private synchronized void createUser(UserRegistrationData data) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
