ittuann commented on PR #2884: URL: https://github.com/apache/streampipes/pull/2884#issuecomment-2122854782
> How did you execute pre-commit? If I'm running `make pre-commit` this does not fail which is due to the fact that it does not watch tests files We should adapt that as well because such issues should bring the CI to fail The command I executed is: `poetry run pre-commit run --verbose --all-files` CI does not execute tests in the `tests` directory because the path pattern 'streampipes/**/*' used in the git ls-files command excludes the tests directory. https://github.com/apache/streampipes/blob/f8f9ee3dba05721fbbcb23ef9121c147cfb4fed4/streampipes-client-python/Makefile#L50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
