bossenti commented on code in PR #2884: URL: https://github.com/apache/streampipes/pull/2884#discussion_r1609400582
########## streampipes-client-python/Makefile: ########## @@ -47,7 +47,7 @@ reformat-all: .PHONY: pre-commit pre-commit: - git ls-files -- 'streampipes/**/*' | xargs poetry run pre-commit run --verbose --files Review Comment: We can do it this way, but since this is used as pre-commit hook I'd prefer to only scan the changed files Scanning all files causes some unnecessary latency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
