tenthe commented on code in PR #4271:
URL: https://github.com/apache/streampipes/pull/4271#discussion_r2979734851
##########
ui/src/app/pipeline-details/components/pipeline-details-toolbar/pipeline-details-toolbar.component.html:
##########
@@ -66,5 +66,35 @@
color="accent"
>{{ 'Auto refresh' | translate }}
</mat-slide-toggle>
+ <button
+ mat-icon-button
+ [matMenuTriggerFor]="optMenu"
+ [attr.aria-label]="'Options' | translate"
+ data-cy="pipeline-details-options"
+ >
+ <mat-icon>more_vert</mat-icon>
+ </button>
+ <mat-menu #optMenu="matMenu">
Review Comment:
Hi @Nguyen-Bang,
I think the Copilot comment is valid here. If the user doesn’t have pipeline
write privileges, the menu will be empty. You could wrap the entire menu in the
if statement.
##########
ui/projects/streampipes/shared-ui/src/lib/dialog/confirm-dialog/confirm-dialog.component.ts:
##########
@@ -16,7 +16,7 @@
*
*/
-import { Component, inject } from '@angular/core';
+import { Component, HostListener, Inject } from '@angular/core';
Review Comment:
I introduced this bug when resolving the merge conflicts
##########
ui/projects/streampipes/shared-ui/src/lib/dialog/confirm-dialog/confirm-dialog.component.ts:
##########
@@ -16,7 +16,7 @@
*
*/
-import { Component, inject } from '@angular/core';
+import { Component, HostListener, Inject } from '@angular/core';
Review Comment:
```suggestion
import { Component, HostListener, inject } from '@angular/core';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
