tenthe commented on PR #4271: URL: https://github.com/apache/streampipes/pull/4271#issuecomment-4119230978
> > Hi @Nguyen-Bang, > > thanks a lot for this PR, really nice work. I just have a small change request. > > I also liked the shortcut descriptions you added in the PR. It might be useful to show these in the application as well. Maybe we could add a simple overview page listing all shortcuts, and include a link to it in the top-right menu. > > <img alt="Image" width="1504" height="814" src="https://private-user-images.githubusercontent.com/5279561/568223183-64998f27-846d-46ed-afe8-4f8a216d225d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzQzNjUzNTcsIm5iZiI6MTc3NDM2NTA1NywicGF0aCI6Ii81Mjc5NTYxLzU2ODIyMzE4My02NDk5OGYyNy04NDZkLTQ2ZWQtYWZlOC00ZjhhMjE2ZDIyNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDMyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAzMjRUMTUxMDU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDdhNzYyNDdmNWE4YzEzYjE4Yzg0MWRjY2Q2ODc4NjgxMmM5YmUzMGRkZDc0MmM0ZTE4NjBmNDI3NmI4NGYzZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.uNDq5_Fljcpjl-cucFWX6t7HEbYhmvFt5iWQX-YAoZA";> > > Hi @tenthe, Thanks for the feedback. Wouldn't it make more sense to include a shortcut guide in the official docs? Of course I could also add an icon to the menu bar that pops up a window with all the shortcuts. Yeah, good point, I had the same idea but wasn’t sure if the StreamPipes UI is the better place for it. Having it in the documentation works fine for me as well. My thought was that users might find it more easily in the UI, but at the same time it’s not very obvious that this kind of info would live in that menu. What do you think? I’m fine with either approach, happy to go with what you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/5279561/568223183-64998f27-846d-46ed-afe8-4f8a216d225d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzQzNjUzNTcsIm5iZiI6MTc3NDM2NTA1NywicGF0aCI6Ii81Mjc5NTYxLzU2ODIyMzE4My02NDk5OGYyNy04NDZkLTQ2ZWQtYWZlOC00ZjhhMjE2ZDIyNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDMyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAzMjRUMTUxMDU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDdhNzYyNDdmNWE4YzEzYjE4Yzg0MWRjY2Q2ODc4NjgxMmM5YmUzMGRkZDc0MmM0ZTE4NjBmNDI3NmI4NGYzZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.uNDq5_Fljcpjl-cucFWX6t7HEbYhmvFt5iWQX-YAoZA"](https://private-user-images.githubusercontent.com/5279561/568223183-64998f27-846d-46ed-afe8-4f8a216d225d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzQzNjUzNTcsIm5iZiI6MTc3NDM2NTA1NywicGF0aCI6Ii81Mjc5NTYxLzU2ODIyMzE4My02NDk5OGYyNy04NDZkLTQ2ZWQtYWZlOC00ZjhhMjE2ZDIyNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDMyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAzMjRUMTUxMDU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDdhNzYyNDdmNWE4YzEzYjE4Yzg0MWRjY2Q2ODc4NjgxMmM5YmUzMGRkZDc0MmM0ZTE4NjBmNDI3NmI4NGYzZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.uNDq5_Fljcpjl-cucFWX6t7HEbYhmvFt5iWQX-YAoZA"){kind=link}