I have to agree with you. Even fixing things after the fact is good. I was reacting to my efforts of two weekends ago when I spent asignificant fraction of the weekend editing a co-workers code to correct Checkstyle problems. Along the way I used the time to do a quick code review. I included lots of todo tags to falg items for later discussion and or resolution.
Unfortunately this developer is still writing code without comments, that won't pass checkstyle and not a single unit test in sight. As the Administrator of the system we are using, that I built to do this continuous integration, it will take a special notice from my boss to allow this application into Preproduction testing woithout the above mentioned items in place. I just cannot condone nor accept unprofessional efforts from the developers. I was hired to teach Best Practices, not how to do the minimum. I rely heavily on Open Source efforts and have generally found them to be of high quality. It always helps to find they are well documented, checkstyled, and unit tested. I would be willing to help out on an effort to improve any project in this respect. Given the excellent IDE's there is really little or no reason not to set the IDE correctly and then use it. The big three, Eclipse, NetBeans and JDeveloper (especially the latest version) are very helpful at this kind of thing. In the end though, someone has to put the brains behind it all to write meaningful javadocs and good code reviews. -- Ivan S Kirkpatrick, PE home 850 656 9107 cell 253 229 6605 Sooner or later, you're bound to go... --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
