On 1/19/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> Try reverting to version 1.3.1 of the plugin

OK, that worked just fine, and I can run Jalopy as a Maven task.

Of course, as Frank reported, Jalopy is not reformatting everything it
could, especialy long lines.

I tried reformatting the Action subproject with Jalopy, IDEA, and then
combinations of the two. Here's the skinny:

Action CheckStyle Errors

4887 Status Quo
2677 Jalopy
2483 IDEA + Jalopy
2100 IDEA
2033 Jalopy + IDEA

The Status Quo  report is here
* http://struts.apache.org/struts-action/checkstyle-report.html

The trial reports are here:
 * http://people.apache.org/~husted/checkstyle/

If the goal is to reduce CheckStyle errors to zero, running Jalopy and
then IDEA seems to be the best starting point. Once the codebase is
back up to snuff, I expect Jalopy (and a vigilant PMC) will be
sufficient.

For each subproject, starting with the Action Library, my intention would be to

* Reformat using our IDEA settings; check-in
* Address non-functional errors manually (Javadoc comments and such); check-in
* Address functional errors (non-encapsulated fields and such); check-in

and see how close we can come to zero Checkstyle errors in a
reasonable amount of time.

-Ted.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to