On 2/5/06, Ted Husted <[EMAIL PROTECTED]> wrote:
> I'd be happy to fix the Javadoc issues. It's mainly a matter of
> inserting a blank line before using exotic elements, like an unordered
> list.
Okay. :)
> The main use of IDEA in this case is to redress past errors. Once we
> are over this hump, just running the Jalopy task and watching the
> Checkstyle reports should be enough. The major style check that Jalopy
> is not fixing is long lines.
If IDEA is going to be a one time thing, and Jalopy is to be made part
of the build, then IDEA probably needs to be run before Jalopy, even
if that means fewer complaints get fixed. Right now, Jalopy wants to
make additional changes in struts-action, such as:
protected ForwardConfig execute(ActionContext context, Action action,
- ActionConfig actionConfig,
- ActionForm actionForm)
- throws Exception {
+ ActionConfig actionConfig, ActionForm actionForm)
+ throws Exception {
ServletActionContext saContext = (ServletActionContext) context;
That's just indentation and wrapping, but which one is correct, and
which setting controls it?
The long lines are a problem. Not fixing them is one thing, but it
wants to make this change, which *creates* a line longer than 80
characters:
- protected String processorClass =
- "org.apache.struts.chain.ComposableRequestProcessor";
+ protected String processorClass =
"org.apache.struts.chain.ComposableRequestProcessor";
I've asked on the Jalopy sf.net forum, but it isn't very active.
Google turned up this post which might be the config that Forrest is using:
http://www.nabble.com/Re:-Automated-formatting-of-Java-files-p712099.html
Frank: The JEdit plugin was able to import the jalopy_struts.xml file
that I checked into current/build, and export a version with changes.
The Maven plugin uses Jalopy 1.0b11, and the JEdit plugin uses 1.0b7,
which seems to be close enough.
This might help, though it's probably for the upcoming 1.5 version:
https://sourceforge.net/forum/forum.php?thread_id=1405105&forum_id=148156
Besides IDEA and Jalopy, are there any other code formatting tools we
should be considering? We're so close to the Sun code conventions, it
seems like this shouldn't be so hard to do.
Thanks,
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
