On 2/5/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:

> The long lines are a problem.  Not fixing them is one thing, but it
> wants to make this change, which *creates* a line longer than 80
> characters:
>
> -    protected String processorClass =
> -            "org.apache.struts.chain.ComposableRequestProcessor";
> +    protected String processorClass =
> "org.apache.struts.chain.ComposableRequestProcessor";

>From the sf.net forum:
   "Preferences->printer->wrapping->wrap after assignments (make sure
this is checked)"

I'm not using the GUI, but that was enough of a hint, and r375446
seems to have helped.

But Jalopy is still insisting on long lines for method declarations,
such as (in ActionForm):
    public ActionErrors validate(ActionMapping mapping, ServletRequest
request) {

and for method calls (in ActionRedirect):
        
result.append("parameterString=").append(getParameterString()).append("]");
(though that one could just as well be split into two lines.)

It also makes this change:
-        } else {
+        }
+        else {
which causes Checkstyle to complain that '} should be on the same line'.

Patches for the config file (build/jalopy_struts.xml) are welcome! 
I'm testing with 'maven jalopy' in struts-action.  Since it was
already reformatted, it's easy to see (with 'svn diff') where Jalopy
is making changes that it shouldn't.

Thanks,
Wendy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to