Thanks for the feedback!

On 6/12/07, Tom Schneider <[EMAIL PROTECTED]> wrote:

1. I'm not sure the UrlRendererFactory is needed.  I believe the whole
purpose of guice is to not have anymore factories anymore, so guice
should just inject the necessary UrlRenderer.  (especially if they are
stateless)

Ah....of course... I just saw some other "factories" when trying to
figure out how the injection works, and assumed wrong. I'll remove
them.


2. As a first step in separating out the url building logic I like how
you have the form url building seperate from the typical url building.
I tried to combine these and couldn't find a clean way to resolve the
differences.

HTH,
Tom

Yeah, I couldn't find a way to combine them either. So I think
separating them, for now, is the easiest route to go.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to