Everything should be included in the default build. We can add a profile to exclude the plugin from building, just like we did with assembly.
musachy On Mon, Aug 24, 2009 at 9:18 AM, Paul Benedict<[email protected]> wrote: > If JDK6 is required to run, then I think two things should be done: > * A profile be created to build this plugin > * The maven-enforcer-plugin should enforce the use of at least JDK 1.6 > > Paul > > On Mon, Aug 24, 2009 at 10:48 AM, Chris Pratt <[email protected]>wrote: > >> Yes, for the EmbeddedJSP plugin, it would require Java6+, but the rest of >> Struts 2 (everything we have today) would work fine with Java 5. So I >> can't >> really see a need for separate J5 and J6 releases. Noting that that single >> plugin requires Java6 seems sufficient to me. >> (*Chris*) >> >> On Mon, Aug 24, 2009 at 7:01 AM, Al Sutton <[email protected]> wrote: >> >> > I guess that depends on whether; >> > >> > "The EmbeddedJSP plugin's JSPLoader uses javax.tools.JavaCompiler that is >> > "Since 1.6" only" >> > >> > means used during the compile or used during runtime. >> > >> > Al. >> > >> > -- >> > >> > * Written an Android App? - List it at http://andappstore.com/ * >> > >> > ====== >> > Funky Android Limited is registered in England & Wales with the >> > company number 6741909. The registered head office is Kemp House, >> > 152-160 City Road, London, EC1V 2NX, UK. >> > >> > The views expressed in this email are those of the author and not >> > necessarily those of Funky Android Limited, it's associates, or it's >> > subsidiaries. >> > >> > -----Original Message----- >> > From: [email protected] [mailto:[email protected]] >> On >> > Behalf Of Paul Benedict >> > Sent: 24 August 2009 14:39 >> > To: Struts Developers List >> > Subject: Re: Build requires JDK 1.6 now - EmbeddedJSP plugin >> > >> > Isn't only the build requiring JDK 6? It's not that JDK 6 is required at >> > run-time. If that's the case, I don't think this is a big deal. >> > >> > On Mon, Aug 24, 2009 at 1:07 AM, Al Sutton <[email protected]> wrote: >> > >> > > My opinion is to go J6 with a J5 optional package. >> > > >> > > That way users can get as much as we can give them out of the box and >> if >> > > they really must only use J5 they can still do so. >> > > >> > > We'll also have to make sure we don't use String.isEmpty :). >> > > >> > > Al. >> > > >> > > -- >> > > >> > > * Written an Android App? - List it at http://andappstore.com/ * >> > > >> > > ====== >> > > Funky Android Limited is registered in England & Wales with the >> > > company number 6741909. The registered head office is Kemp House, >> > > 152-160 City Road, London, EC1V 2NX, UK. >> > > >> > > The views expressed in this email are those of the author and not >> > > necessarily those of Funky Android Limited, it's associates, or it's >> > > subsidiaries. >> > > >> > > -----Original Message----- >> > > From: Wes Wannemacher [mailto:[email protected]] >> > > Sent: 24 August 2009 04:26 >> > > To: Struts Developers List >> > > Subject: Re: Build requires JDK 1.6 now - EmbeddedJSP plugin >> > > >> > > On Sunday 23 August 2009 09:48:55 pm Jeromy Evans wrote: >> > > > Hi guys, >> > > > >> > > > I may have missed the announcement, but it seems Java 1.6 is now >> > > > mandatory to perform a full build of Struts 2.1.8+ >> > > > >> > > > The EmbeddedJSP plugin's JSPLoader uses javax.tools.JavaCompiler that >> > > > is "Since 1.6" only. >> > > > >> > > > If not deliberate, we may need a j5 profile in the build that >> excludes >> > > > that module (is that even possible?) >> > > > >> > > >> > > We could easily create a profile that doesn't include the embeddedjsp >> > > plugin >> > > (and any other new modules that may require java 6). The real question >> is >> > > whether we want to continue targeting Java 5 and exclude the Java 6 >> stuff >> > > by >> > > default or vice versa? I'll go see if google can tell me about the >> > lifespan >> > > of >> > > Java 5. >> > > >> > > -Wes >> > > >> > > -- >> > > Wes Wannemacher >> > > >> > > Head Engineer, WanTii, Inc. >> > > Need Training? Struts, Spring, Maven, Tomcat... >> > > Ask me for a quote! >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > >> > -- "Hey you! Would you help me to carry the stone?" Pink Floyd --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
