2017-11-07 7:17 GMT+01:00 Yasser Zamani <yasser.zam...@live.com>: > I agree. Good for cases such [1], however, not good for [2] for example > where commit 1 and 2 should not be squashed as I intentionally separated > them to enable easier track of changes and concepts. > > [1] https://github.com/apache/struts/pull/173 > [2] https://github.com/apache/struts/pull/167
Yeah... it's not always a good idea to Squash commits, I think we need a common sense and explicitly say that this PR can be squashed instead of merged. We can use a label or type in directly in the description, something like "Please squash this PR" Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
