On 11/15/2017 1:26 PM, Lukasz Lenart wrote:
We can use a label or type in directly in the description, something like "Please squash this PR"
Yes, I think as it rarely happens, maybe a new github label is not needed. Instead, when merger feels a squash suitable case then discusses pull requester to squash which commits.
I also think we should not squash to only decrease commit counts. Instead, we should honor "easy to track how and why the changes are made, via enough modular commits counts, not more, not less". When squash helps this, then we do it.
Regards, Yasser. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
