On 2/20/2018 1:37 PM, Lukasz Lenart wrote: > 2018-02-20 10:21 GMT+01:00 Yasser Zamani <yasserzam...@apache.org>: >>> This is not needed as the reload check was moved into >>> FileManager#fileNeedsReloading methods - see usage of those methods. >> >> Yes I saw. However, FileManager#fileNeedsReloading method depends on if >> `revision = files.get` is null or not i.e. depends on if the file is >> under monitor or not, and as loadFile always calls monitorFile then >> currently, every loaded file is under monitor regardless of if user has >> set `struts.configuration.xml.reload` constant to true or not. > > but FileManager#fileNeedsReloading won't be called if > "struts.configuration.xml.reload" is set to false, see > ConfigurationManager#conditionalReload
Thanks Łukasz! you were right. Then to sum up, Struts monitors all loaded files regardless of devMode or "struts.configuration.xml.reload" values (i.e. user may get a warning exception if framework was not able to create a revision for loaded file). But Struts checks if reload is needed only when "struts.configuration.xml.reload" constant is set to true (devMode still doesn't make sense). Looks good to me however it seems javadocs of FileManager interface should being fixed to satisfy these. Regards. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
