yuanzac commented on a change in pull request #92: SUBMARINE-276. Submarine
runtime class config should be defined in the new configuration class.
URL: https://github.com/apache/submarine/pull/92#discussion_r346213079
##########
File path:
submarine-client/src/main/java/org/apache/submarine/client/cli/AbstractCli.java
##########
@@ -42,11 +42,11 @@ public abstract int run(String[] args)
@Override
public void setConf(Configuration conf) {
- clientContext.setSubmarineConfig(conf);
+ clientContext.setConfiguration(conf);
}
@Override
public Configuration getConf() {
- return clientContext.getSubmarineConfig();
+ return clientContext.getYarnConfig();
Review comment:
The method getConf and setConf is defined in Tool class, which is from
Hadoop code.
So we can't change them to getConfiguration or getYarnConfiguration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
