yuanzac commented on a change in pull request #92: SUBMARINE-276. Submarine runtime class config should be defined in the new configuration class. URL: https://github.com/apache/submarine/pull/92#discussion_r346215570
########## File path: submarine-server/server-submitter/submitter-yarn/src/main/java/org/apache/submarine/server/submitter/yarn/YarnUtils.java ########## @@ -33,7 +33,7 @@ import java.util.List; import java.util.Map; -import static org.apache.submarine.commons.runtime.conf.SubmarineConfiguration.SUBMARINE_RUNTIME_APP_TYPE; +import static org.apache.submarine.commons.utils.SubmarineConfiguration.SUBMARINE_RUNTIME_APP_TYPE; Review comment: SUBMARINE_RUNTIME_APP_TYPE is another configuration. It defines the application type in the yarn. With it, Yarn UI show job type as submarine not tony. This configuration is added in #24 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
